Update SARIF format #534
Merged
Update SARIF format #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #534 +/- ##
==========================================
+ Coverage 77.05% 78.36% +1.31%
==========================================
Files 76 77 +1
Lines 5129 5251 +122
==========================================
+ Hits 3952 4115 +163
+ Misses 1011 971 -40
+ Partials 166 165 -1
|
oliverchang
reviewed
Sep 14, 2023
cmd/osv-scanner/main_test.go
Outdated
| "name": "osv-scanner", | ||
| "rules": [ | ||
| { | ||
| "id": "GHSA-whgm-jr23-g3j9", |
There was a problem hiding this comment.
Should we have an end-to-end test here that includes CVE, Ecosystem ID examples etc?
There was a problem hiding this comment.
Added a bigger test with CVE's and multiple ecosystems, not as an end-to-end test but a unit test since it makes the path resolution easier. It already found some problems with CVEs not actually being the display ID, which should be fixed now.
Do you still want a bigger end-to-end test as well?
oliverchang
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #216 with a new format that separates out individual vulnerabilities.
Each vulnerability is now it's own rule violation. The aliased vulnerabilities are grouped together as one rule violation, with an ID picked in this priority (CVE -> [Eco Specific] -> GHSA).